Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BWAPILauncher error message unclear when missing config file #4

Open
malcolmsharpe opened this issue Oct 23, 2017 · 2 comments
Open

Comments

@malcolmsharpe
Copy link

When running BWAPILauncher without a config file, it simply prints:

Error: file_reader: failed to open  for reading

(This message observed on MacOS and Linux.)

This is a bit confusing, because it's not clear what file it was trying to read. (In fact, I suspect this is not complaining about failing to read the config file, but about failing to read the map, which presumably has a blank default value.)

I'd propose printing an error (or at least warning) when the config file isn't found, as well as clarifying the error when failing to read the map.

@tscmoo
Copy link
Collaborator

tscmoo commented Nov 28, 2017

You're right, it has a blank default value. An error message would be useful here.

@shedatc
Copy link

shedatc commented May 8, 2018

I submitted some fixes to help there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants