file_reader: Assert filename must not be empty

[shedatc]

Used to troubleshoot #4. Probably worth keeping it.

[tscmoo]

Hi,

Unfortunately, assert() only works in debug builds, which makes the check not very useful. Also an assertion failure does not really provide a more descriptive error as far as #4 is concerned, anyways.

#4 really should be fixed in BWAPI, not here (openbw should give more descriptive errors and perhaps not always fatally quit, but that's a greater effort).

Is there any particular reason for the character -> sdl constants change? SDL is supposed to be abstracted away from this file, so including it is something I really want to avoid - in fact e.sym should correspond with the character constants, and not the sdl constants.

[shedatc]

Unfortunately, assert() only works in debug builds, which makes the check not very useful. Also an assertion failure does not really provide a more descriptive error as far as #4 is concerned, anyways.

OK no problem.

#4 really should be fixed in BWAPI, not here (openbw should give more descriptive errors and perhaps not always fatally quit, but that's a greater effort).

Yes, I also submitted a PR for that.

Is there any particular reason for the character -> sdl constants change? SDL is supposed to be abstracted away from this file, so including it is something I really want to avoid - in fact e.sym should correspond with the character constants, and not the sdl constants.

No, that's just I'm a noob :/ I should have created a branch before starting to work on UI-related changes…