Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create a coordinate picker modal to edit area lat lon form (#1129) #1133

Merged
merged 12 commits into from
Jun 3, 2024

Conversation

clintonlunn
Copy link
Collaborator

@clintonlunn clintonlunn commented May 16, 2024


name: Pull request
about: Create a pull request
title: ''
labels: ''
assignees: ''


What type of PR is this?(check all applicable)

  • refactor
  • feature
  • bug fix
  • documentation
  • optimization
  • other

Description

  • add modal with map embedded into it
  • update the AreaLatLngForm.tsx form when confirming
  • basic test
  • custom popup

Related Issues

Issue #1129

What this PR achieves

This pr is to add a coordinate picker within a modal that updates the Area Lat Lon form.

Screenshots, recordings

image
image

pickerpopup.mp4

Notes

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
open-tacos ✅ Ready (Inspect) Visit Preview Jun 1, 2024 3:23am

@clintonlunn clintonlunn linked an issue May 19, 2024 that may be closed by this pull request
@clintonlunn clintonlunn requested a review from vnugent May 30, 2024 02:00
@clintonlunn clintonlunn marked this pull request as ready for review May 30, 2024 02:00
@clintonlunn clintonlunn changed the title feat: create a coordinate picker modal to edit area lat lon (#1129) feat: create a coordinate picker modal to edit area lat lon form (#1129) Jun 3, 2024
@vnugent
Copy link
Contributor

vnugent commented Jun 3, 2024

@clintonlunn thanks for this. I'll merge it as it. Some suggestions which we can do in a follow up PR

  • show existing coordinates
  • show new location. Maybe with a different icon (crosshair?)
  • reuse confirm dialog

Screenshot 2024-06-03 at 5 56 41 PM

@vnugent vnugent merged commit 10a2e6e into develop Jun 3, 2024
10 checks passed
@vnugent vnugent deleted the coordinate-picker branch June 3, 2024 16:39
@clintonlunn
Copy link
Collaborator Author

@vnugent thanks for the suggestions, and I definitely agree. I'll create some issues and would definitely like to take on those tasks.

In addition, I'd like to modify how the dialog title is styled because the title can overflow onto the X button. I think using instead of hard coding the position, using flex box would be a better approach. i have some changes to the global.css file that i made to address this, but thought it was a little out of scope of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coordinates picker
2 participants