Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add contributors map json file #896

Merged
merged 3 commits into from
Jul 2, 2023
Merged

Conversation

actuallyyun
Copy link
Collaborator

Issue #893

Is /assets a good place for this file?
For the map UI, I assume we want to put it in /about page, what do you think? @vnugent

@vercel
Copy link

vercel bot commented Jun 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
open-tacos ✅ Ready (Inspect) Visit Preview Jul 2, 2023 10:20pm

@actuallyyun actuallyyun requested a review from vnugent June 30, 2023 08:27
@vnugent
Copy link
Contributor

vnugent commented Jun 30, 2023

What do you think if we use Geojson format instead of regular json? The benefit is GitHub natively supports geojson file.

Example taken from your data

{
  "type": "FeatureCollection",
  "features": [
    {
      "type": "Feature",
      "properties": {
        "firstName": "Yun",
        "favoriteCrag": "8fe4fa78-fda9-5742-b807-00b2c31d7bcd"
      },
      "geometry": {
        "type": "Point",
        "coordinates": [
          0.905152180850496,
          41.26613040056221
        ]
      },
      "id": 0
    }
  ]
}
{
  "type": "FeatureCollection",
  "features": [
    {
      "type": "Feature",
      "properties": {
        "firstName": "Yun",
        "favoriteCrag": "8fe4fa78-fda9-5742-b807-00b2c31d7bcd"
      },
      "geometry": {
        "type": "Point",
        "coordinates": [
          0.905152180850496,
          41.26613040056221
        ]
      },
      "id": 0
    }
  ]
}
Loading

@vnugent
Copy link
Contributor

vnugent commented Jun 30, 2023

Issue #893

Is /assets a good place for this file? For the map UI, I assume we want to put it in /about page, what do you think? @vnugent

Yes

@actuallyyun
Copy link
Collaborator Author

"id": 0

That's nice. How should we handle the "id" field? Ask people to manually increment?

@vnugent
Copy link
Contributor

vnugent commented Jul 1, 2023

"id": 0

That's nice. How should we handle the "id" field? Ask people to manually increment?

id is not required. We can take that field out.

Can you also mention the order of coordinates is [longitude, latitude]?

@actuallyyun
Copy link
Collaborator Author

"id": 0

That's nice. How should we handle the "id" field? Ask people to manually increment?

id is not required. We can take that field out.

Can you also mention the order of coordinates is [longitude, latitude]?

Will do!

@vnugent vnugent merged commit 068a962 into develop Jul 2, 2023
11 checks passed
@vnugent vnugent deleted the add-contributors-map-file branch July 2, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants