Tick import error #969
Tick import error #969
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…component and references in apps #913
|
@vnugent I've been testing this and I believe it is pretty much feature complete. The only reason I have been holding it in draft is to try to get better test coverage, but I am still struggling with mocking some of these loading states and toast messages. That can probably be improved down the road though. |
| <button | ||
| type='button' | ||
| onClick={getTicks} | ||
| className='btn btn-primary' | ||
| > | ||
| {loading ? <Spinner /> : 'Get my ticks!'} | ||
| </button> |
There was a problem hiding this comment.
I'd disable the button if loading is in progress
<button
disabled={loading}
... 
|
I was able to continue clicking on "Get my tick!" while the import is in progress (the spinner is showing), causing multiple imports. Don't worry about unit testing for now. As discussed the workflow will likely change. 
|
|
Got the button disabled while loading, Other than that, I think we want to cancel the request if the user clicks cancel. Working on that now |
fixes #913
name: Pull request
about: Create a pull request
title: ''
labels: ''
assignees: ''
What type of PR is this?(check all applicable)
Description
Related Issues
Issue #913
What this PR achieves
react-toastifyfor improved error notifications.headlessuimodal forLeanAlertfor UI consistency.Screenshots, recordings
error messages and the new import mountain project modal
Notes
I removed some unused
isButtonlogic that doesn't seem to be used anywhere anymore. This really simplified the component.