Merge pull request #1772 from OpenC3/release-polish

Small bug fixes and enhancements
OpenC3 · Dec 17, 2024 · 88594fc · 88594fc
2 parents 6cbf4f0 + e55627b
commit 88594fc
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 3 deletions.
diff --git a/docs.openc3.com/static/img/telemetry_viewer/widgets/scrollwindow.png b/docs.openc3.com/static/img/telemetry_viewer/widgets/scrollwindow.png
diff --git a/...ugins/packages/openc3-cosmos-tool-dataextractor/src/tools/DataExtractor/DataExtractor.vue b/...ugins/packages/openc3-cosmos-tool-dataextractor/src/tools/DataExtractor/DataExtractor.vue
@@ -426,7 +426,11 @@ export default {
       this.saveDefaultConfig(this.currentConfig)
     },
     cmdOrTlm: function () {
-      this.saveDefaultConfig(this.currentConfig)
+      if (this.items.length === 0) { // just to prevent the save from happening twice
+        this.saveDefaultConfig(this.currentConfig)
+      } else {
+        this.items = []
+      }
     },
     items: {
       handler: function () {

diff --git a/.../plugins/packages/openc3-cosmos-tool-packetviewer/src/tools/PacketViewer/PacketViewer.vue b/.../plugins/packages/openc3-cosmos-tool-packetviewer/src/tools/PacketViewer/PacketViewer.vue
@@ -50,6 +50,9 @@
       <v-data-table
         :search="search"
         :headers="headers"
+        :header-props="{
+          style: 'width: 50%',
+        }"
         :items="rows"
         :custom-filter="filter"
         :sort-by="sortBy"

diff --git a/openc3-cosmos-init/plugins/packages/openc3-vue-common/src/components/Openc3Screen.vue b/openc3-cosmos-init/plugins/packages/openc3-vue-common/src/components/Openc3Screen.vue
@@ -308,10 +308,13 @@ export default {
     },
     computedStyle() {
       let style = {}
+      // note down what the width was in case it was set to AUTO, because absolute positioning will lose that
+      const origWidth = this.width || this.$refs.bar?.clientWidth
       if (this.floated) {
         style['position'] = 'absolute'
         style['top'] = this.top + 'px'
         style['left'] = this.left + 'px'
+        style['width'] = origWidth + 'px'
       }
       return style
     },

diff --git a/openc3-cosmos-init/plugins/packages/openc3-vue-common/src/widgets/Widget.js b/openc3-cosmos-init/plugins/packages/openc3-vue-common/src/widgets/Widget.js
@@ -81,8 +81,11 @@ export default {
         this.applyStyleSetting(setting)
       })
 
-      // If nothing has yet defined a width then we add flex to the style
-      if (this.appliedStyle['width'] === undefined) {
+      // If nothing has yet defined a width or height then we add flex to the style
+      if (
+        this.appliedStyle['width'] === undefined &&
+        this.appliedStyle['height'] === undefined
+      ) {
         // This flex allows for alignment in our widgets
         // The value of '0 10 100%' was achieved through trial and error
         // The larger flex-shrink value was critical for success