update comments. Fix unit tests

OpenC3 · Sep 16, 2022 · ca10ae2 · ca10ae2
1 parent 4f9c36a
commit ca10ae2
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 10 deletions.
diff --git a/openc3-init/plugins/packages/openc3-accessor-test/Rakefile b/openc3-init/plugins/packages/openc3-accessor-test/Rakefile
@@ -1,6 +1,6 @@
 # encoding: ascii-8bit
 
-# Copyright 2022 Ball Aerospace & Technologies Corp.
+# Copyright 2022 OpenC3, Inc.
 # All Rights Reserved.
 #
 # This program is free software; you can modify and/or redistribute it
@@ -13,10 +13,6 @@
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU Affero General Public License for more details.
 
-# Modified by OpenC3, Inc.
-# All changes Copyright 2022, OpenC3, Inc.
-# All Rights Reserved
-
 PLUGIN_NAME = Dir['*.gemspec'][0].split('.')[0..-2].join('.')
 
 task :require_version do

diff --git a/openc3-init/plugins/packages/openc3-accessor-test/openc3-accessor-test.gemspec b/openc3-init/plugins/packages/openc3-accessor-test/openc3-accessor-test.gemspec
@@ -13,7 +13,6 @@
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU Affero General Public License for more details.
 
-# Create the overall gemspec
 spec = Gem::Specification.new do |s|
   s.name = 'openc3-accessor-test'
   s.summary = 'OpenC3 Accessor Example Plugin'

diff --git a/openc3-init/plugins/packages/openc3-accessor-test/targets/ACCESS/lib/sim_access.rb b/openc3-init/plugins/packages/openc3-accessor-test/targets/ACCESS/lib/sim_access.rb
@@ -13,7 +13,7 @@
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU Affero General Public License for more details.
 
-# Provides a demonstration of a accessors
+# Provides a demonstration of accessors
 
 require 'openc3'
 

diff --git a/openc3/data/config/command_modifiers.yaml b/openc3/data/config/command_modifiers.yaml
@@ -181,7 +181,7 @@ TEMPLATE:
 TEMPLATE_FILE:
   summary: Defines a template file used to initialize the command before default values are filled in
   description: Generally the template file is formatted in JSON or HTML and then values are filled in with
-    command parameters. Must be UTF-8 encoded.
+    command parameters. Can be binary or UTF-8.
   parameters:
     - name: Template File Path
       required: true

diff --git a/openc3/lib/openc3/packets/packet.rb b/openc3/lib/openc3/packets/packet.rb
@@ -295,7 +295,7 @@ def buffer=(buffer)
         begin
           internal_buffer_equals(buffer)
         rescue RuntimeError
-          if BinaryAccessor === @accessor
+          if BinaryAccessor == @accessor
             Logger.instance.error "#{@target_name} #{@packet_name} received with actual packet length of #{buffer.length} but defined length of #{@defined_length}"
           end
         end

diff --git a/openc3/spec/packets/packet_config_spec.rb b/openc3/spec/packets/packet_config_spec.rb
@@ -523,9 +523,9 @@ module OpenC3
           @pc.process_file(tf.path, "SYSTEM")
           expect(@pc.telemetry["TGT1"]["PKT1"].template).to eq "File data"
           expect(@pc.commands["TGT2"]["PKT1"].template).to eq "relative file"
+          File.delete(File.dirname(tf.path) + '/' + filename)
           data_file.unlink
           tf.unlink
-          File.delete(File.dirname(tf.path) + '/' + filename)
         end
       end