Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use response.content (bytes) instead of response.text (encoded text) #1148

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

ryanmelt
Copy link
Member

No description provided.

@ryanmelt ryanmelt requested a review from jmthomas March 17, 2024 03:02
@ryanmelt ryanmelt changed the title use response.content (bytes) instead of response.txt (encoded text) use response.content (bytes) instead of response.text (encoded text) Mar 17, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.00%. Comparing base (e825c03) to head (9fa24a8).
Report is 2 commits behind head on main.

Files Patch % Lines
openc3/python/openc3/script/storage.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1148      +/-   ##
==========================================
+ Coverage   74.98%   75.00%   +0.02%     
==========================================
  Files         594      594              
  Lines       43900    43900              
  Branches      757      757              
==========================================
+ Hits        32917    32928      +11     
+ Misses      10899    10888      -11     
  Partials       84       84              
Flag Coverage Δ
frontend 55.31% <ø> (+0.01%) ⬆️
python 83.04% <0.00%> (+0.07%) ⬆️
ruby-api 48.73% <ø> (ø)
ruby-backend 80.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this ever work in the docker compose version? Why was this unique to k8?

@ryanmelt
Copy link
Member Author

The difference is in docker compose we are using local mode which is a different code path than k8s which doesn't support local mode.

@ryanmelt ryanmelt merged commit 5fd7f61 into main Mar 17, 2024
24 checks passed
@ryanmelt ryanmelt deleted the fix_python_get_target_file branch March 17, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants