Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed version tag from compose.yaml, compose-dev.yaml, and compose-… #1160

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

schuuust
Copy link

Docker Compose obsoleted the version tag. As a result, containers using the tag began to throw warnings at the user that it became obsolete.

I removed the version tags from compose.yaml, compose-dev.yaml, and compose-build.yaml to comply with this new Docker Compose standard. Interacting with COSMOS Docker containers no longer warns the user about deprecated tags.

Closes issue #1159

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.98%. Comparing base (7e4dd0f) to head (6f7236d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1160      +/-   ##
==========================================
- Coverage   75.01%   74.98%   -0.03%     
==========================================
  Files         595      595              
  Lines       43910    43910              
  Branches      757      757              
==========================================
- Hits        32939    32928      -11     
- Misses      10888    10898      +10     
- Partials       83       84       +1     
Flag Coverage Δ
frontend 55.28% <ø> (-0.15%) ⬇️
python 83.02% <ø> (-0.03%) ⬇️
ruby-api 48.71% <ø> (ø)
ruby-backend 80.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanmelt
Copy link
Member

Thanks!

@ryanmelt ryanmelt merged commit 1ae95b7 into OpenC3:main Mar 27, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants