Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OPENC3_BUCKET_URL in storage #1163

Merged
merged 2 commits into from
Mar 30, 2024
Merged

Fix OPENC3_BUCKET_URL in storage #1163

merged 2 commits into from
Mar 30, 2024

Conversation

jmthomas
Copy link
Member

No description provided.

@jmthomas jmthomas requested a review from ryanmelt March 29, 2024 14:19
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 75.01%. Comparing base (1ae95b7) to head (22833a3).

Files Patch % Lines
openc3/lib/openc3/script/storage.rb 0.00% 2 Missing ⚠️
openc3/python/openc3/script/storage.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1163   +/-   ##
=======================================
  Coverage   75.00%   75.01%           
=======================================
  Files         595      595           
  Lines       43914    43914           
  Branches      757      757           
=======================================
+ Hits        32939    32941    +2     
+ Misses      10892    10889    -3     
- Partials       83       84    +1     
Flag Coverage Δ
frontend 55.37% <ø> (ø)
python 83.02% <0.00%> (+0.01%) ⬆️
ruby-api 48.71% <ø> (ø)
ruby-backend 80.05% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanmelt
Copy link
Member

Need to fix ruby unit tests

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jmthomas jmthomas merged commit b370451 into main Mar 30, 2024
24 checks passed
@jmthomas jmthomas deleted the bucket_url branch March 30, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants