Fix python suites #1164
Merged
Fix python suites #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmthomas
commented
Mar 30, 2024
| @@ -2125,6 +2125,7 @@ class TestSuite(Suite): | |||
| let pythonRegex2 = new RegExp( | |||
| '^\\s*(if|def|while|else|elif|class).*:\\s*$', | |||
| ) | |||
| let pythonRegex3 = new RegExp('\\(f"') // f strings | |||
There was a problem hiding this comment.
(f" doesn't exist anywhere in our ruby code
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1164 +/- ##
==========================================
- Coverage 75.00% 74.98% -0.02%
==========================================
Files 595 595
Lines 43914 43917 +3
Branches 757 758 +1
==========================================
- Hits 32939 32933 -6
- Misses 10892 10900 +8
- Partials 83 84 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jmthomas
commented
Mar 30, 2024
| if ( | ||
| result.exceptions and group_class.abort_on_exception | ||
| ) or result.stopped: | ||
| raise StopScript |
There was a problem hiding this comment.
Lots of bad indentation was breaking running Groups and Suites
|
ryanmelt
approved these changes
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.