Fix Posix Serial Driver Not Unblocking Read on Close #1166
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1166 +/- ##
==========================================
+ Coverage 74.98% 74.99% +0.01%
==========================================
Files 595 595
Lines 43914 43922 +8
Branches 757 757
==========================================
+ Hits 32928 32940 +12
+ Misses 10903 10898 -5
- Partials 83 84 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| begin | ||
| read_ready, _ = IO.fast_select(@readers, nil, nil, @read_timeout) | ||
| rescue IOError | ||
| @pipe_reader.close unless @pipe_reader.closed? |
There was a problem hiding this comment.
I don't see how closing the pipe_reader is going to help with the serial port handle
There was a problem hiding this comment.
Closing the pipe reader is just to make sure we don't leave file handles open. Return "" means that we are dead and should no longer be used going forward. IOError should only occur if the serial port has already been closed.
| @pipe_reader.close unless @pipe_reader.closed? | ||
| return "" | ||
| else | ||
| retry |
There was a problem hiding this comment.
This jumps back to the read_nonblock right?
| if read_ready | ||
| if read_ready.include?(@pipe_reader) | ||
| @pipe_reader.close unless @pipe_reader.closed? | ||
| return "" |
There was a problem hiding this comment.
Why would you close the pipe_reader if the read_ready says it's ready?
There was a problem hiding this comment.
pipe_reader is only ever ready, if pipe_writer was written. That means we have been closed.
|
This mostly the same code from sleeper.rb. |
No description provided.