Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add username to Execution status #1189

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Add username to Execution status #1189

merged 2 commits into from
Apr 12, 2024

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Apr 7, 2024

closes #1182

@jmthomas jmthomas requested a review from ryanmelt April 7, 2024 00:28
@jmthomas
Copy link
Member Author

jmthomas commented Apr 7, 2024

Screenshot 2024-04-06 at 6 25 01 PM

Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 74.99%. Comparing base (89c5d5d) to head (d8798e3).
Report is 2 commits behind head on main.

Files Patch % Lines
...s-script-runner-api/app/models/completed_script.rb 0.00% 2 Missing ⚠️
...mos-script-runner-api/app/models/running_script.rb 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1189      +/-   ##
==========================================
+ Coverage   74.98%   74.99%   +0.01%     
==========================================
  Files         595      595              
  Lines       43926    43924       -2     
  Branches      758      758              
==========================================
+ Hits        32937    32941       +4     
+ Misses      10906    10899       -7     
- Partials       83       84       +1     
Flag Coverage Δ
frontend 55.35% <ø> (+0.01%) ⬆️
python 83.03% <ø> (+0.04%) ⬆️
ruby-api 48.69% <0.00%> (-0.02%) ⬇️
ruby-backend 80.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
4.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@jmthomas jmthomas merged commit 798ff88 into main Apr 12, 2024
15 of 17 checks passed
@jmthomas jmthomas deleted the script_user branch April 12, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScriptRunner Execution Status pane show user
2 participants