Remove slice! from fixed_protocol #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmthomas
commented
Apr 17, 2024
| # and 1000x slower at large packets (1Mb) | ||
| # Run test/benchmarks/string_mod_benchmark.rb for details | ||
| packet_data = @data[0...identified_packet.defined_length + @discard_leading_bytes] | ||
| @data = @data[(identified_packet.defined_length + @discard_leading_bytes)..-1] |
There was a problem hiding this comment.
I think this is equivalent functionality. I tried to add a new test case to the spec but not sure if I fully covered the case because if you change ..-1 to ..-2 it still passes
ryanmelt
requested changes
Apr 28, 2024
| # But slice! is 6x slower at small packets (1024) | ||
| # and 1000x slower at large packets (1Mb) | ||
| # Run test/benchmarks/string_mod_benchmark.rb for details | ||
| packet_data = @data[0...identified_packet.defined_length + @discard_leading_bytes] |
There was a problem hiding this comment.
Is this intentionally ... and shouldn't there be parens around the + expression?
There was a problem hiding this comment.
Order of operations applies plus before range but it's clearer with parens
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.