IGNORE_OVERLAP in telemetry #1208
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1208 +/- ##
==========================================
+ Coverage 74.92% 76.47% +1.55%
==========================================
Files 599 575 -24
Lines 44200 42551 -1649
Branches 759 759
==========================================
- Hits 33115 32540 -575
+ Misses 11001 9928 -1073
+ Partials 84 83 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @target_name = target_name.upcase.freeze | ||
| else | ||
| @target_name = nil | ||
| end | ||
| @target_name |
There was a problem hiding this comment.
I understand this is redundant, but I like explicit returns. Should be "return @target_name"
There was a problem hiding this comment.
A setter should not have a return. That's why I removed it ... not because it was implicit
There was a problem hiding this comment.
|
closes #1202
Branched from #1201 because that introduced test_packet_config.py file