Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

burst protocol c extension #1225

Merged
merged 2 commits into from
May 2, 2024
Merged

burst protocol c extension #1225

merged 2 commits into from
May 2, 2024

Conversation

ryanmelt
Copy link
Member

@ryanmelt ryanmelt commented May 2, 2024

Speed improvements are unfortunately pretty small in the benchmarking I did. 0-5%

@ryanmelt ryanmelt requested a review from jmthomas May 2, 2024 00:28
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

jmthomas
jmthomas approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performance improvements seem pretty small to maintain a separate C extension but it seems to work

@ryanmelt ryanmelt merged commit 3c85603 into main May 2, 2024
16 of 17 checks passed
@ryanmelt ryanmelt deleted the read_data_c_extension branch May 2, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmthomas jmthomas jmthomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanmelt @jmthomas