Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright changes for enterprise #1244

Merged
merged 2 commits into from
May 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
<v-tabs-items v-model="curTab">
<v-tab-item v-for="(tab, index) in config.tabs" :key="tab.ref" eager>
<keep-alive>
<v-card flat>
<v-card flat style="height: 90vh">
<v-divider />
<v-card-title class="pa-3">
<span v-text="tab.name" />
Expand Down
1 change: 1 addition & 0 deletions playwright/tests/limits-monitor.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ test('changes the limits set', async ({ page, utils }) => {
await page.getByRole('button', { name: 'Limits Set' }).click()
await page.getByRole('option', { name: 'TVAC' }).click()
await page.getByRole('button', { name: 'Ok' }).click()
await utils.sleep(10000) // Limits set updated every 10s
expect(await page.getByLabel('Current Limits Set').inputValue()).toBe('TVAC')
await expect(page.locator('[data-test=limits-events]')).toContainText(
'Setting Limits Set: TVAC',
Expand Down
5 changes: 4 additions & 1 deletion playwright/tests/script-runner/file-menu.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,10 @@ test('open a file', async ({ page, utils }) => {
})

test('open a file using url param', async ({ page, utils }) => {
await page.goto('/tools/scriptrunner?file=INST2/procedures/collect.py')
await page.goto('/tools/scriptrunner?file=INST2/procedures/collect.py', {
waitUntil: 'domcontentloaded',
})
await utils.sleep(1000)
expect(await page.locator('#sr-controls')).toContainText(
`INST2/procedures/collect.py`,
)
Expand Down
4 changes: 4 additions & 0 deletions playwright/tests/script-runner/suite.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,7 @@ test('starts a suite', async ({ page, utils }) => {
end
end
`)
await utils.sleep(500)
// Verify filename is marked as edited
expect(await page.locator('#sr-controls')).toContainText('*')
// Save the new values which should refresh the controls
Expand All @@ -300,6 +301,7 @@ test('starts a suite', async ({ page, utils }) => {
} else {
await page.keyboard.press('Control+S')
}
await utils.sleep(500)

// Verify the suite startup, teardown buttons are disabled
await expect(page.locator('[data-test=setup-suite]')).toBeDisabled()
Expand Down Expand Up @@ -394,6 +396,7 @@ test('starts a group', async ({ page, utils }) => {
end
end
`)
await utils.sleep(500)
// Verify filename is marked as edited
expect(await page.locator('#sr-controls')).toContainText('*')
// Save the new values which should refresh the controls
Expand All @@ -402,6 +405,7 @@ test('starts a group', async ({ page, utils }) => {
} else {
await page.keyboard.press('Control+S')
}
await utils.sleep(500)

// Verify the group startup, teardown buttons are disabled
await expect(page.locator('[data-test=setup-group]')).toBeDisabled()
Expand Down
3 changes: 2 additions & 1 deletion scripts/release/package_audit_lib.rb
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@

def get_docker_version(path)
args = {}
version = ''
File.open(path) do |file|
file.each do |line|
if line.include?("ARG")
Expand All @@ -45,10 +46,10 @@ def get_docker_version(path)
if version.include?("${")
version = args[version[2..-2]]
end
return version
end
end
end
return version
end

def make_sorted_hash(name_versions)
Expand Down
Loading