Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right click screen keyword for docs #1252

Merged
merged 3 commits into from
May 23, 2024
Merged

Right click screen keyword for docs #1252

merged 3 commits into from
May 23, 2024

Conversation

jmthomas
Copy link
Member

closes #1180

@jmthomas jmthomas requested a review from ryanmelt May 10, 2024 04:58
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.43%. Comparing base (1caf8c9) to head (94e957d).
Report is 63 commits behind head on main.

Current head 94e957d differs from pull request most recent head de8599e

Please upload reports for the commit de8599e to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1252      +/-   ##
==========================================
+ Coverage   52.42%   52.43%   +0.01%     
==========================================
  Files         197      197              
  Lines        9452     9470      +18     
  Branches      759      760       +1     
==========================================
+ Hits         4955     4966      +11     
- Misses       4414     4420       +6     
- Partials       83       84       +1     
Flag Coverage Δ
frontend 55.19% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

showContextMenu: function (event) {
this.menuX = event.pageX
this.menuY = event.pageY
this.docsKeyword = this.editor.getSelectedText()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems really fragile. Shouldn't it find the first word of the line and select that. What if nothing is selected and I just right click on the word?

Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jmthomas jmthomas merged commit f102321 into main May 23, 2024
18 checks passed
@jmthomas jmthomas deleted the tlm_viewer_docs branch May 23, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TlmViewer get docs for widget keyword
2 participants