Python script runner api #1282
Merged
Python script runner api #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanmelt
requested changes
May 21, 2024
|
|
||
|
|
||
| # Require an additional python file | ||
| def load_utility(procedure_name): |
There was a problem hiding this comment.
load_utility and require_utility need to work differently in Python.
If I require_utility or load_utility I should expect to have new methods to call. (like the collect() utility method from collect.py)
ryanmelt
requested changes
May 22, 2024
| @@ -45,8 +45,6 @@ def load_utility(procedure_name): | |||
| return False | |||
|
|
|||
|
|
|||
| require_utility = load_utility | |||
There was a problem hiding this comment.
This is breaking. There is no harm in supporting both require_utility and load_utility.
| # not_cached = require(procedure_name) | ||
| pass | ||
| else: | ||
| raise RuntimeError("load_utility not support outside of Script Runner") |
| @@ -1339,7 +1335,6 @@ def load_utility(procedure_name): | |||
|
|
|||
|
|
|||
| setattr(openc3.script, "load_utility", load_utility) | |||
| setattr(openc3.script, "require_utility", load_utility) | |||
There was a problem hiding this comment.
This is breaking, don't remove.
|
|
||
|
|
||
| # Require an additional python file | ||
| def load_utility(procedure_name): |
| def test_load_utility_raises(self): | ||
| with self.assertRaisesRegex( | ||
| RuntimeError, | ||
| "load_utility not support outside of Script Runner", |
ryanmelt
approved these changes
May 22, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic implementation done but wanted to discuss the best way to test (not tested currently)
closes #1281