Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SR aware of roles #1308

Merged
merged 5 commits into from
Jun 12, 2024
Merged

Make SR aware of roles #1308

merged 5 commits into from
Jun 12, 2024

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented May 31, 2024

closes #1299
closes #1298

@jmthomas jmthomas requested a review from ryanmelt May 31, 2024 06:02
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 57.37705% with 26 lines in your changes missing coverage. Please review.

Project coverage is 75.18%. Comparing base (c18bbdb) to head (9ef7428).
Report is 31 commits behind head on main.

Files Patch % Lines
...riptrunner/src/tools/ScriptRunner/ScriptRunner.vue 54.54% 23 Missing and 2 partials ⚠️
...enc3-cosmos-script-runner-api/app/models/script.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1308       +/-   ##
===========================================
+ Coverage   49.59%   75.18%   +25.59%     
===========================================
  Files         123      600      +477     
  Lines        6735    44656    +37921     
  Branches      760      777       +17     
===========================================
+ Hits         3340    33576    +30236     
- Misses       3310    10993     +7683     
- Partials       85       87        +2     
Flag Coverage Δ
frontend 55.28% <56.14%> (+0.11%) ⬆️
python 83.65% <ø> (?)
ruby-api 48.59% <50.00%> (+23.03%) ⬆️
ruby-backend 80.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmthomas
Copy link
Member Author

There's something still weird because the 'viewer' user can't seem to open Suites. It looks like something related to the offline access token.

Copy link

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jmthomas jmthomas merged commit 4efb42b into main Jun 12, 2024
25 checks passed
@jmthomas jmthomas deleted the sr_roles branch June 12, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScriptRunner UI Permissions Aware (Enterprise) Suite Runner Log Messages pane sizing issue
2 participants