Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow array index in VALUE widget #1332

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Allow array index in VALUE widget #1332

merged 3 commits into from
Jun 17, 2024

Conversation

jmthomas
Copy link
Member

closes #1303

@jmthomas jmthomas requested a review from ryanmelt June 12, 2024 16:28
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.19%. Comparing base (c552eca) to head (2e9be0b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1332      +/-   ##
==========================================
- Coverage   75.21%   75.19%   -0.03%     
==========================================
  Files         600      600              
  Lines       44676    44680       +4     
  Branches      777      777              
==========================================
- Hits        33603    33596       -7     
- Misses      10986    10997      +11     
  Partials       87       87              
Flag Coverage Δ
frontend 55.38% <ø> (-0.17%) ⬇️
python 83.64% <ø> (-0.02%) ⬇️
ruby-api 48.59% <ø> (ø)
ruby-backend 80.00% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanmelt
Copy link
Member

I know someone was creating their actual mnemonics with ITEM_NAME[0] as the actual mnemonic name. I don't remember if we updated the internal code to handle that (I think we did).
If so this will break that use case. Is there any way to handle both?

@jmthomas
Copy link
Member Author

jmthomas commented Jun 12, 2024

I'm allowing bracket values in telemetry screens as long as they are escaped: TKT PKT ITEM[[0]]. If you don't escape: TGT PKT ITEM[1] it means try to index into an array item.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jmthomas jmthomas merged commit 31f5499 into main Jun 17, 2024
25 checks passed
@jmthomas jmthomas deleted the array_widget branch June 17, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screen Widget for displaying Individual Array Items?
2 participants