Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for string param when doing range checking #1337

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

jmthomas
Copy link
Member

No description provided.

@jmthomas jmthomas requested a review from ryanmelt June 14, 2024 20:03
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.21%. Comparing base (c552eca) to head (9549c30).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1337   +/-   ##
=======================================
  Coverage   75.21%   75.21%           
=======================================
  Files         600      600           
  Lines       44676    44676           
  Branches      777      777           
=======================================
+ Hits        33603    33605    +2     
+ Misses      10986    10985    -1     
+ Partials       87       86    -1     
Flag Coverage Δ
frontend 55.59% <ø> (+0.05%) ⬆️
python 83.64% <ø> (-0.01%) ⬇️
ruby-api 48.59% <ø> (ø)
ruby-backend 80.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanmelt
Copy link
Member

Good fix for the bug. We still need to figure out how strings were ending up there though before closing this PR.

@ryanmelt
Copy link
Member

I think the original issue was caused by sending a command with a manually entered state value which sends a blank string by default. Fix works.

@ryanmelt ryanmelt merged commit 159229c into main Jun 25, 2024
25 checks passed
@ryanmelt ryanmelt deleted the py_str_param branch June 25, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants