Fix applying global settings to widgets #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmthomas
commented
Jun 18, 2024
| @@ -540,7 +540,8 @@ i.v-icon.mdi-chevron-down { | |||
| } | |||
| .graph-info { | |||
| width: 140px; | |||
| margin-left: 70px; | |||
| margin-left: 20px; | |||
| margin-top: 65px; | |||
There was a problem hiding this comment.
This was just a simply fix the little helper text on TlmGrapher
|
jmthomas
commented
Jun 18, 2024
| // Recursively apply to all widgets contained in layouts | ||
| if (widget.widgets) { | ||
| this.applyGlobalSettings(widget.widgets) | ||
| } |
There was a problem hiding this comment.
Nesting this inside the forEach loops caused the page to freeze if you have more than a few global settings and nested widgets.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1350 +/- ##
==========================================
+ Coverage 75.21% 75.22% +0.01%
==========================================
Files 600 600
Lines 44676 44680 +4
Branches 777 777
==========================================
+ Hits 33602 33611 +9
+ Misses 10987 10983 -4
+ Partials 87 86 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ryanmelt
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.