Adjust logging output #1385
Adjust logging output #1385
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1385 +/- ##
==========================================
- Coverage 75.40% 75.36% -0.04%
==========================================
Files 600 600
Lines 44687 44689 +2
Branches 777 777
==========================================
- Hits 33694 33682 -12
- Misses 10906 10920 +14
Partials 87 87
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -29,7 +29,7 @@ | |||
| show-size | |||
| accept=".gem" | |||
| class="mx-2" | |||
| label="Click to select plugin .gem file to install" | |||
| label="Click to install new plugin .gem (NOT upgrade)" | |||
There was a problem hiding this comment.
I wanted this to be clearer that this is for installing new plugins. I think we're still getting people clicking here for upgrade which leads to the "already exists" error.
There was a problem hiding this comment.
The real fix for this is a new "Are you sure" prompt that lets the user know that the plugin they are trying to install has already been installed at least once. This info could be returned in the results from install_phase1
| end | ||
| end | ||
|
|
||
| def shutdown | ||
| @shutdown = true | ||
| @mutex.synchronize do | ||
| Logger.info("Shutting down processes...") |
| shutdown_processes(@processes) | ||
| Logger.info("Shutting down processes complete") | ||
| Logger.debug("Shutting down processes complete") |
| @@ -174,7 +174,7 @@ def hard_stop | |||
| if @process and !@process.exited? | |||
| # Redis may be down at this point so just catch any Logger errors | |||
| begin | |||
| Logger.info("Hard shutting down process: #{cmd_line()}", scope: @scope) | |||
| Logger.debug("Hard shutting down process: #{cmd_line()}", scope: @scope) | |||
| @@ -161,7 +161,7 @@ def exit_code | |||
|
|
|||
| def soft_stop | |||
| Thread.new do | |||
| Logger.info("Soft shutting down process: #{cmd_line()}", scope: @scope) | |||
| Logger.debug("Soft shutting down process: #{cmd_line()}", scope: @scope) | |||
| @@ -29,7 +29,7 @@ | |||
| show-size | |||
| accept=".gem" | |||
| class="mx-2" | |||
| label="Click to select plugin .gem file to install" | |||
| label="Click to install new plugin .gem (NOT upgrade)" | |||
There was a problem hiding this comment.
The real fix for this is a new "Are you sure" prompt that lets the user know that the plugin they are trying to install has already been installed at least once. This info could be returned in the results from install_phase1
|
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
Added #1398 to address issue about installing with "Are you sure" prompt. |
No description provided.