Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal widget #1386

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Signal widget #1386

merged 3 commits into from
Jul 9, 2024

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Jul 7, 2024

closes #1377

@jmthomas jmthomas requested a review from ryanmelt July 7, 2024 22:12
@jmthomas
Copy link
Member Author

jmthomas commented Jul 7, 2024

Screenshot 2024-07-07 at 4 00 02 PM

Copy link

codecov bot commented Jul 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.37%. Comparing base (0ab3dc8) to head (14bce77).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1386      +/-   ##
==========================================
- Coverage   75.40%   75.37%   -0.03%     
==========================================
  Files         600      600              
  Lines       44687    44689       +2     
  Branches      777      777              
==========================================
- Hits        33694    33683      -11     
- Misses      10906    10918      +12     
- Partials       87       88       +1     
Flag Coverage Δ
frontend 55.34% <ø> (-0.22%) ⬇️
python 83.93% <ø> (-0.02%) ⬇️
ruby-api 48.60% <ø> (+0.04%) ⬆️
ruby-backend 80.20% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


HORIZONTAL
LABELVALUE INST HEALTH_STATUS TEMP1
SIGNAL INST HEALTH_STATUS TEMP1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screens should use <%= target_name %>

SETTING TLM INST2 HEALTH_STATUS TEMP4
ROLLUP satellite-transmit "Satellite" "all temps"
SETTING SCREEN INST2 HS
SETTING TLM INST2 HEALTH_STATUS TEMP1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screens should use <%= target_name %>

Copy link

sonarqubecloud bot commented Jul 9, 2024

@jmthomas jmthomas merged commit de1fa10 into main Jul 9, 2024
25 checks passed
@jmthomas jmthomas deleted the signal_widget branch July 9, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Signal Strength Bar Widget (Like Cell Phone)
2 participants