Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra connect in python_microservice #1400

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Remove extra connect in python_microservice #1400

merged 1 commit into from
Jul 13, 2024

Conversation

jmthomas
Copy link
Member

closes #1362

@jmthomas jmthomas requested a review from ryanmelt July 13, 2024 15:06
Copy link

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.40%. Comparing base (c85245c) to head (c1d8eda).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1400   +/-   ##
=======================================
  Coverage   75.40%   75.40%           
=======================================
  Files         600      600           
  Lines       44701    44700    -1     
  Branches      777      777           
=======================================
+ Hits        33705    33708    +3     
+ Misses      10908    10905    -3     
+ Partials       88       87    -1     
Flag Coverage Δ
frontend 55.41% <ø> (+0.03%) ⬆️
python 84.01% <ø> (+0.01%) ⬆️
ruby-api 48.60% <ø> (ø)
ruby-backend 80.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmthomas jmthomas merged commit 2478e65 into main Jul 13, 2024
26 checks passed
@jmthomas jmthomas deleted the python_connect branch July 13, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Python interfaces seem to have connect() method called twice
2 participants