Fix scope_model and add comments #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmthomas
commented
Jul 24, 2024
| @@ -113,6 +113,7 @@ def create(update: false, force: false, queued: false) | |||
| # Ensure there are no "." in the scope name - prevents gems accidently becoming scope names | |||
| raise "Invalid scope name: #{@name}" if @name !~ /^[a-zA-Z0-9_-]+$/ | |||
| @name = @name.upcase | |||
| @scope = @name # Ensure @scope matches @name | |||
There was a problem hiding this comment.
@scope is used by all the deployment steps and without this it is not uppercase
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1433 +/- ##
=======================================
Coverage 75.63% 75.64%
=======================================
Files 603 603
Lines 44827 44828 +1
Branches 787 787
=======================================
+ Hits 33907 33909 +2
Misses 10832 10832
+ Partials 88 87 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.