Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile. Add vim and ps to UBI images #1441

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Conversation

ryanmelt
Copy link
Member

No description provided.

@ryanmelt ryanmelt requested a review from jmthomas July 27, 2024 02:16
@ryanmelt ryanmelt merged commit 1b863af into main Jul 27, 2024
16 checks passed
@ryanmelt ryanmelt deleted the uninstall_protobuf branch July 27, 2024 02:17
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@@ -24,9 +24,11 @@ RUN mkdir -p lib/openc3/ext \
&& mkdir -p gems \
&& mv *.gem gems/. \
# TODO: Remove google-protobuf / grpc manually install once grpc fixed
# Uninstall twice is intentional because --all doesn't work
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the previous double install because I thought it was a typo. Thanks for the comment! Hopefully this all goes away soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants