-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generator requires language #1490
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1490 +/- ##
==========================================
- Coverage 75.88% 75.87% -0.01%
==========================================
Files 609 609
Lines 45328 45328
Branches 787 787
==========================================
- Hits 34397 34393 -4
- Misses 10844 10847 +3
- Partials 87 88 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just need to update the github actions to explicitly pass --ruby now
Quality Gate passedIssues Measures |
There is no longer a default language for the generators.
If OPENC3_LANGUAGE is not set, the final argument to bundle exec ruby bin/openc3cli generate must be --ruby or --python.
If OPENC3_LANGUAGE is set, it must be exactly ruby or python.
If OPENC3_LANGUAGE is set, the final argument can be (missing or) anything other than --ruby or --python, then OPENC3_LANGUAGE will be used.
If both are set but only one is correct, the correct one will be used.
If neither are set or both are incorrect the script will abort with a descriptive message.
NOTE: the command line arguments must have the leading dashes, but the ENV var must not.