Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator requires language #1490

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Generator requires language #1490

merged 5 commits into from
Aug 21, 2024

Conversation

JL-Brothers
Copy link
Contributor

@JL-Brothers JL-Brothers commented Aug 20, 2024

There is no longer a default language for the generators.

If OPENC3_LANGUAGE is not set, the final argument to bundle exec ruby bin/openc3cli generate must be --ruby or --python.

If OPENC3_LANGUAGE is set, it must be exactly ruby or python.

If OPENC3_LANGUAGE is set, the final argument can be (missing or) anything other than --ruby or --python, then OPENC3_LANGUAGE will be used.

If both are set but only one is correct, the correct one will be used.

If neither are set or both are incorrect the script will abort with a descriptive message.

NOTE: the command line arguments must have the leading dashes, but the ENV var must not.

@JL-Brothers JL-Brothers requested a review from jmthomas August 20, 2024 22:19
@JL-Brothers JL-Brothers linked an issue Aug 20, 2024 that may be closed by this pull request
@JL-Brothers JL-Brothers self-assigned this Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.87%. Comparing base (e8ca743) to head (922bdde).
Report is 44 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1490      +/-   ##
==========================================
- Coverage   75.88%   75.87%   -0.01%     
==========================================
  Files         609      609              
  Lines       45328    45328              
  Branches      787      787              
==========================================
- Hits        34397    34393       -4     
- Misses      10844    10847       +3     
- Partials       87       88       +1     
Flag Coverage Δ
frontend 54.96% <ø> (+0.05%) ⬆️
python 84.07% <ø> (-0.06%) ⬇️
ruby-api 48.97% <ø> (ø)
ruby-backend 81.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just need to update the github actions to explicitly pass --ruby now

Copy link

@jmthomas jmthomas merged commit a099866 into main Aug 21, 2024
26 checks passed
@jmthomas jmthomas deleted the Generator-requires-language branch August 21, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generators should require --ruby or --python
3 participants