Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct spelling errors #1496

Merged
merged 12 commits into from
Aug 26, 2024
Merged

Correct spelling errors #1496

merged 12 commits into from
Aug 26, 2024

Conversation

jmthomas
Copy link
Member

No description provided.

@jmthomas jmthomas requested a review from ryanmelt August 23, 2024 23:02
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.58%. Comparing base (238a63d) to head (f358716).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1496      +/-   ##
==========================================
- Coverage   76.59%   76.58%   -0.01%     
==========================================
  Files         608      608              
  Lines       45386    45381       -5     
  Branches      798      798              
==========================================
- Hits        34764    34757       -7     
- Misses      10534    10536       +2     
  Partials       88       88              
Flag Coverage Δ
frontend 55.82% <ø> (-0.05%) ⬇️
python 84.23% <ø> (ø)
ruby-api 49.00% <ø> (ø)
ruby-backend 82.29% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.question {
font-size: 1rem;
white-space: pre-line;
}
</sytle>
</style>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual bug

@@ -77,7 +76,7 @@ def set(name:, value:, type: nil, unit: nil, help: nil, labels: nil, time_ms: ni
end

def set_multiple(data)
@mutex.synchonize do
@mutex.synchronize do
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual bug

Copy link
Member

@ryanmelt ryanmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of spelling errors!
One spelling error still "discret" is French.
Also please add a spell checker to our CI/CD pipeline so that these don't start building up again.


1. **Script Runner**

- Script Runner allows for running OpenC3 COSMOS test procedures or any other Ruby code from a graphical environment that highlights each line as it executes. At anytime during execution, the script can be paused or stopped. If a telemetry check fails or any other exception occurs, the script is immediately stopped and the user notified.

- Script Runner also allows you to break your operational or test procedures down into discreet test cases that each complete with either SUCCESS or FAILURE. After running, a script report is automatically created for you. Convenient features such as the ability to loop testing help get the kinks out of your system before formal runs.
- Script Runner also allows you to break your operational or test procedures down into discret test cases that each complete with either SUCCESS or FAILURE. After running, a script report is automatically created for you. Convenient features such as the ability to loop testing help get the kinks out of your system before formal runs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be discrete

@github-advanced-security
Copy link
Contributor

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

This comment has been minimized.

Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (1187)
abcd
ABCDEFGHIJ
abcxxx
acediff
acequire
ACFFC
ACKCMD
aclfile
aclocal
actioncable
actionpack
activatable
adcs
addgroup
Addrinfo
addstopums
addums
adduser
admins
advapi
AGPL
airgap
ajd
alabel
allbits
allchannels
allkeys
ALLOWMULTISELECT
amazonaws
amd
anchore
Anish
apid
apk
appendonly
apps
appstream
aquasecurity
aref
P'arser
ARYCMD
asciicmd
aset
ASo
aspx
astro
astrouxds
aton
attprogress
autocompleteception
autofocus
Autohide
automake
Autoset
avgvals
avs
babelrc
BACKCOLOR
backticks
bak
basearch
baseos
baz
beforeunload
bezier
biasx
biasy
biasz
BIGNUM
bigpatch
binmode
bitap
bitfield
bitoffset
bitsize
blankline
Blength
blocktest
bobspassword
BORDERCOLOR
boto
botocore
bottomleft
bottomright
boxbanner
bplr
bplw
brc
bridgegem
bridgesetup
browserslistrc
bucketexplorer
buildx
byebug
byscore
byteorder
byteorderlist
cacheable
CAinfo
canvasdot
CANVASELLIPSE
canvasimage
canvasimagevalue
canvaslabel
canvaslabelvalue
canvasline
canvaslinevalue
capistrano
carryforward
caueses
CAVGVALS
cbor
CBORCMD
CBORTLM
ccsds
CCSDSAPID
CCSDSDATA
ccsdsheader
ccsdslength
ccsdsseqcnt
CCSDSSEQFLAGS
CCSDSSHF
CCSDSTYPE
CCSDSVER
CCSDSVERSION
cdk
CDNs
cfdp
cflag
cfromq
Changle
chgport
childprocess
Chome
chromeless
cindex
cjs
CLA
clamav
clamscan
classificaiton
classificiation
clazz
clearallscreens
clearfix
clickable
cliroot
CLOCAL
cls
clsx
cmdauth
CMDORTLM
CMDPKT
cmds
cmdsender
cmdtlmserver
cmn
cnt
cobertura
codecov
codegen
codeql
codeready
coefficents
coeffs
Colorstr
colspan
combobox
commandlog
commmandlog
commonlength
commonsuffix
COMMTIMEOUTS
comparision
compressobj
COMPUTERNAME
COMX
contextmenu
corre
COSIDX
cosmosc
cosmoscache
Cov
cpfx
CRCs
CREATEPROMPT
crt
CRTSCTS
CSDSSHF
CSTDDEVVALS
cstol
CSTOPB
cstyle
ctx
curveto
cvals
cvar
CVEs
cvt
Cyclomatic
cyclonedx
cygwin
dabcdef
darkorange
dataextractor
datastore
dataviewer
dataviewerquaternion
dataviewertime
Dataviewerxxxxx
dbaeumer
dct
ddeg
ddn
DEADBEEF
decom
DECOMCMD
decomcmdlog
DECOMINTERFACE
decomlog
decommutated
decommutation
defaul
defrag
defxxx
deliniated
deliniation
destroyscope
devkit
DFF
DFL
DFLTS
DGRAM
diffed
diffing
diffs
diffsb
DIMENTIONAL
DIMESIONAL
discret
dline
dlopen
dmp
dmsnell
dnf
dns
Dockerfiles
DOCKERHUB
domcontentloaded
DONTADDTORECENT
DONTWAIT
dothtml
DOTMATCH
downloadfile
draggable
drb
DSL
dso
dsz
Dtr
DVB
EADDRINUSE
EALREADY
EBA
editorbox
editorconfig
EINPROGRESS
EINTR
ENABLEDELAYEDEXPANSION
enableds
ENABLEHOOK
ENABLEINCLUDENOTIFY
ENABLESIZING
ENABLETEMPLATE
ENABLETEMPLATEHANDLE
endianness
endline
endproc
ENDTIME
entrypoints
eot
epel
Ephemeralping
epohc
eql
EQU
erb
erbtest
Erorr
errinfo
esac
esbenp
ESRCH
eus
evemts
EVENPARITY
evt
EXAMPLESTART
EXAMPLESTATUS
excepthandler
exitstatus
explict
extconf
EXTENSIONDIFFERENT
Extrator
EYWORD
fakepm
fakeredis
favicons
fcontext
fdescribe
FFF
ffi
fieldname
fieldset
fild
filechooser
FILEMUSTEXIST
fileoverview
finalbody
Finalizer
findstr
findutils
firefox
fixcenter
fixlinux
fixnum
fixwindows
flexbox
FLTCMD
Fluentd
FNM
fns
FORCESHOWHIDDEN
forfiles
FORMATFONTVALUE
frange
freopen
freshclam
fromhex
fsys
FThis
ftn
funcall
gaierror
gcc
gcp
gdbm
gemdata
gemfile
geminstall
gemspec
gemuninstall
GENCMD
GENTLM
getaddress
getbyte
GETFL
gethostbyaddr
gethostbyname
gethostname
getonly
gettime
gettingstarted
gettlm
ggdb
gitmodules
gmi
gmtime
gosu
gpgcheck
gpgkey
grafana
grapher
grayscale
greenhigh
greenlow
gsb
GSE
GTEQ
guttermousedown
GVsb
handshaked
hardardous
hashtag
haspopup
hazarous
hdel
HDR
healthcheck
helloworld
hget
hgetall
HIDEREADONLY
hiredis
histogramming
hkeys
hmset
horizontalbox
horizontalline
hostedtoolcache
hostenter
hostinstall
hostsetup
hotpink
hoverable
hsc
hset
hsla
HTMLCMD
HTMLTLM
hton
httpclient
HTTPSERVER
hugepage
ico
ICONASTERISK
ICONEXCLAMATION
ICONHAND
ICONQUESTION
IDABORT
IDCANCEL
IDCLOSE
IDHELP
IDIGNORE
IDNO
IDOK
IDRETRY
idx
IDYES
ifdef
iflag
ifm
ifndef
iframe
IGNPAR
IIIIIIIIIIIISSIIII
imageviewer
img
L'imits
imo
importmap
Indeces
Indentical
inet
inhandler
initbuckets
initiallies
innerapp
inputkey
inputvalue
INSTABORT
INSTADCS
instanceof
INSTCLEAR
INSTCOLLECT
INSTHEALTH
instrumentable
instrumentor
Intelli
INTERFACESTATUS
intmodel
ints
ioerror
ipaddr
IPPROTO
irb
ironbank
ispeed
ISTIO
itemname
ITEMX
itensive
itpm
ivar
javascript
jbuilder
jdate
JMES
jmespath
JMT
jmthomas
jpe
JSONCMD
jsoncreates
JSONTLM
jstr
jsx
Karandikar
KEEPALIVE
KEEPCNT
keepends
KEEPIDLE
KEEPINTVL
keycloak
keydown
keyframes
keyspace
keyup
klass
Kroeger
kubernetes
kwags
kwparams
Kxxx
LABELFORMATVALUE
labelledby
labelprogressbar
labelsparkline
LABELTRENDLIMITSBAR
labelvalue
labelvaluedesc
labelvaluelimitsbar
labelvaluelimitscolumn
labelvaluerangebar
LABELVALUERANGECOLUMN
Labview
laggy
Lanuch
largeish
LATESH
lcs
letsencrypt
levelname
levenshtein
lflag
lgs
libedit
libpq
libyaml
lifecycle
limitsbar
limitscolor
limitscolumn
limitsmonitor
limitsresponse
linc
linearray
linebreak
linegraph
linehash
linux
listbox
listitem
lkup
localinit
lol
LONGNAMES
longtext
LOOKASIDE
LPPROCESS
LPSECURITY
LPSTARTUPINFOA
lrow
LTEQ
ltype
P'lugin
luma
lunr
lxml
Macbook
MANPATH
MARKPARITY
matchmask
materialdesignicons
mathiasbynens
matlab
matrixbycolumns
maxtrix
mday
mdc
mdi
mdy
MEGA
memcpy
MEMLOAD
metadat
mfa
microdnf
microfrontend
microservies
middlewares
might've
minid
minio
miniopassword
mjd
mkmf
mkrf
mlr
MMdd
mmm
mnt
mosquitto
mousedown
mouseenter
mouseleave
mouseovers
mouseup
moz
mps
mri
MSOD
mswin
msys
MSYSTEM
mui
multipane
MURRI
mycolor
MYCRC
mydomain
myfile
myicon
myimage
myint
myitem
mykey
mylimits
mylist
myprefix
myresolver
myscreen
mystate
myurl
MYVALUE
namedspaced
namespacing
nbsp
nect
netcom
Neue
NILTYPE
ning
Nnn
NOBLANKS
nobreak
NOCHANGEDIR
noconflict
NODELAY
NODEREFERENCELINKS
nodoc
NOGROUP
nojekyll
NOLONGNAMES
nonblock
Nonel
NONETWORKBUTTON
NONEXISTANT
NONINFRINGEMENT
NOPARITY
nopass
NOPASSWD
NOPLACESBAR
NOREADONLYRETURN
noreturn
NOSCOPE
noscript
NOSONAR
NOTESTFILECREATE
notoast
NOVALIDATE
nproc
nsecs
nsenter
ntoa
ntoh
nxa
nycrc
objectspace
objs
octref
ODDPARITY
oflag
OFN
oky
onbeforeunload
ONDS
ONESTOPBIT
onloadstart
onmousedown
onmousemove
onmouseup
onscroll
oop
openblas
openc
opensource
openssl
opentelemetry
orelse
ospeed
osx
otel
otlp
otp
outdent
Outx
overriden
OVERWRITEPROMPT
owc
packetitem
packetitemlimits
packetlog
packetviewer
pageerror
PARAMX
PARENB
PARODD
passw
PATHMUSTEXIST
pdata
PDFs
peeraddr
pem
Persistentping
pfxs
pidfile
pids
PII
pipinstall
pkgconfig
PKGFILENAME
pkginstall
pkguninstall
pktid
pkts
PKTX
plr
plw
podman
pointerend
pointermax
pointermid
pointermin
pointerstart
POINTSGRAPHED
POINTSSAVED
polyfills
popop
popups
posprogress
postcontext
postline
postpatch
posx
posz
prc
precontext
prefixies
Prefs
Preidentifed
preline
prepatch
presigned
presigner
procps
progid
progressbar
promotes'the
propscolor
protoco
psecrets
psudo
PTK
ptr
puback
pubkey
putc
PWDEBUG
pycrc
pypa
PYTHONUSERBASE
Qfalse
qfromc
qmult
Qnil
qos
Qtrue
quaternions
QUIC
quitquitquit
rackup
RADIOBUTTONs
railtie
railties
rakefile
rangebar
RANGECOLUMN
RARRAY
raspberrypi
rawable
rawtime
rbspy
rds
RDWR
recalulates
recivied
reconsitute
recurrning
redhat
redhigh
rediff
redlow
REDUCEDTYPE
removebase
removeenterprise
reparse
reproducable
requ
resetchannels
resetkeys
resolv
respawn
respawning
responsibily
resync
retryable
REUSEADDR
RFLOAT
rgba
rhel
rii
RMO
RMT
roadmap
roboto
roodi
rootfs
routable
ROUTERSTATUS
rowtext
rpms
E'rror
rrow
rss
RSTRING
RTEST
rtf
rtl
Rts
RTSCTS
Rubyists
rubys
rubysloc
rubyw
runmigrations
runningscript
rus
rxbytes
rxcnt
rxsize
rxtime
ryan
ryanmelt
sadd
sbom
scanable
scanme
SCL
scopecleanup
scopemark
scopemulti
scpi
screenshot
scriptname
scriptrunner
scriptrunnerminio
scriptrunnerminiopassword
scriptrunnerpassword
scrollwindow
SCTP
searchbox
SECONDSGRAPHED
sectionheader
segfault
SELET
seperation
Seqcnt
seqflag
setbyte
SETFL
setkey
setlocal
SETLOGLABEL
setopt
SETPT
setuptools
Sfor
SHAREAWARE
Shf
shorttext
SHOWHELP
sigfigs
signin
signnz
sigsegv
SIOC
sitem
sloc
slrpnl
SLRPNLDEPLOY
SLRPNLRESET
smembers
smui
snippit
snprintf
sockaddr
sortablejs
sourcing
SPACEPARITY
sparams
sparkline
spc
spellcheck
srand
srem
SRPMS
ssn
SSNNNNNNNNN
STARTCMDLOG
STARTF
startline
STARTLOGGING
STARTTIME
STARTTLMLOG
stashef
staticdocs
statictools
STATUSCOLLECTSCONVERTED
STATUSCOLLECTSFORMATTED
STATUSCOLLECTSRAW
STATUSCOLLECTSWITH
STATUSDURATIONCONVERTED
stddev
stddevvals
stderror
stdio
stdlib
stefanzweifel
sti
STOPBITS
STOPCMDLOG
STOPLOGGING
STOPTLMLOG
strcmp
stringio
strlen
Struture
stuartcheshire
stucture
stylesheet
subfolders
subkeys
sublabel
SUBLANG
submodels
subparams
SUBREAPER
subsettings
substr
suffixies
superadmin
Superdata
suppresswarning
svn
sysread
systemjs
tabbook
TABITEM
tabledef
tablefile
tablemanager
tacocat
tagline
targ
targetname
tbl
tbody
tcflush
TCIOFLUSH
Tcp
tcpip
TCSANOW
tcsetattr
telecommand
telemety
telmetry
tempfiles
templase
templated
templating
tesmplate
Testapp
TEXTALIGN
textbox
TEXTCOLOR
textline
tfn
tfoot
Tful
tgm
TGMI
TGMO
TGTX
thead
thr
TIMEFORMATTED
timeinfo
timesec
TIMESECONDS
timestamped
timeus
tini
tio
tional
tlas
tlm
tlmgrapher
TLMPKT
TLMRESPONSE
tlmviewer
tlw
tmpdir
Tmpname
tnames
tokenly
toml
TOOLADMIN
toolbar
toolie
toollist
topbar
topleft
topmenu
topright
tracec
traefik
treeview
TRENDBAR
TRENDLIMITSBAR
trivy
S'tructure
trys
tsc
tsflags
tsx
ttf
ttl
ttyp
TVAC
TWOSTOPBITS
twx
twy
twz
txbytes
txcnt
txsize
txx
txy
txz
TYPEMAP
typeof
tyy
tyz
tzo
tzz
udp
udpreadsocket
udpwritesocket
uints
umasks
umd
umodel
uncompress
undeploy
undeploying
UNEDIT
unfloat
Unidiff
uninstaller
unistd
unmap
unncomment
unsegment
unsegmenting
unsetenv
unsub
updatekey
uplot
upmatch
uppermatch
usec
useconds
userinfo
usermod
usernames
userpath
userroles
uservice
USESHOWWINDOW
USESTDHANDLES
usno
USOMS
usr
utc
uuids
uuidtools
UXDS
vals
valuelimitsbar
valuelimitscolumn
valuerangebar
VALUERANGECOLUMN
valuess
VALUETYPE
vbs
vcid
vecrot
velx
vely
velz
versioned
versioning
verticalbox
vetur
virt
vls
VMIN
VPp
vsls
VTIME
vueify
vuejs
vuetify
vuex
VWidget
webfont
webpages
websecure
website
websockets
whl
whoah
wiget
wii
WIndex
wingrunr
woff
Workaround
WORKDIR
workflows
wss
xadd
xcaj
xdescribe
xinfo
xit
XMLCMD
XMLTLM
Xoff
Xon
xread
xrevrange
xsi
xtce
Xtest
xtrim
xxxabc
xxxdef
xxxxxx
yday
yellowhigh
yellowlow
yieldparam
YMid
yml
YOffset
yourpasswordhere
yyy
YYYYMMDDH
zadd
zcard
zrange
zrangebyscore
zremrangebyscore
zrevrangebyscore
Some files were automatically ignored 🙈

These sample patterns would exclude them:

(?:^|/)\.keep$
(?:^|/)latest\.txt$
(?:|$^ 92.31% - excluded 36/39)(?:^|/)__init__\.py$
/install/config/targets/INST/[^/]+$
[^/]\.bin$
^\Q.gitmodules\E$
^\Qdocs.openc3.com/static/.nojekyll\E$
^\Qopenc3-cosmos-init/plugins/packages/openc3-cosmos-demo/targets/SYSTEM/target.txt\E$
^\Qopenc3-cosmos-init/plugins/packages/openc3-cosmos-erb-test/targets/ERBTEST/target.txt\E$
^\Qopenc3-cosmos-init/plugins/packages/openc3-cosmos-http-example/targets/HTTPCLIENT/target.txt\E$
^\Qopenc3/templates/tool_svelte/build/smui.css\E$

You should consider excluding directory paths (e.g. (?:^|/)vendor/), filenames (e.g. (?:^|/)yarn\.lock$), or file extensions (e.g. \.gz$)

You should consider adding them to:

.github/actions/spelling/excludes.txt

File matching is via Perl regular expressions.

To check these files, more of their words need to be in the dictionary than not. You can use patterns.txt to exclude portions, add items to the dictionary (e.g. by adding them to allow.txt), or fix typos.

To accept these unrecognized words as correct and update file exclusions, you could run the following commands

... in a clone of the git@github.com:OpenC3/cosmos.git repository
on the spelling branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/OpenC3/cosmos/actions/runs/10565974963/attempts/1'
Available 📚 dictionaries could cover words not in the 📘 dictionary
Dictionary Entries Covers Uniquely
cspell:aws/aws.txt 218 17 12
cspell:css/dict/css.txt 263 28 11
cspell:filetypes/filetypes.txt 264 18 11
cspell:node/dict/node.txt 891 32 10
cspell:php/dict/php.txt 1689 36 8

Consider adding them (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@main in its with:

      with:
        extra_dictionaries:
          cspell:aws/aws.txt
          cspell:css/dict/css.txt
          cspell:filetypes/filetypes.txt
          cspell:node/dict/node.txt
          cspell:php/dict/php.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling.yml) for uses: check-spelling/check-spelling@main in its with:

check_extra_dictionaries: ''
Errors (6)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
ℹ️ binary-file 55
❌ check-file-path 3847
ℹ️ large-file 4
ℹ️ no-newline-at-eof 1
ℹ️ noisy-file 4
❌ slow-file 1

See ❌ Event descriptions for more information.

Copy link

@jmthomas jmthomas merged commit abfaab3 into main Aug 26, 2024
27 checks passed
@jmthomas jmthomas deleted the spelling branch August 26, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants