Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fileDialogCallback promise logic #1497

Merged
merged 5 commits into from
Aug 26, 2024

Fix data-viewer spec

aa59a9b
Select commit
Loading
Failed to load commit list.
Merged

Fix fileDialogCallback promise logic #1497

Fix data-viewer spec
aa59a9b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 26, 2024 in 1s

76.56% (-0.03%) compared to 238a63d

View this Pull Request on Codecov

76.56% (-0.03%) compared to 238a63d

Details

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 76.56%. Comparing base (238a63d) to head (aa59a9b).
Report is 13 commits behind head on main.

Files Patch % Lines
...riptrunner/src/tools/ScriptRunner/ScriptRunner.vue 0.00% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1497      +/-   ##
==========================================
- Coverage   76.59%   76.56%   -0.03%     
==========================================
  Files         608      608              
  Lines       45386    45385       -1     
  Branches      798      798              
==========================================
- Hits        34764    34750      -14     
- Misses      10534    10547      +13     
  Partials       88       88

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov