-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cmd validation #1506
Cmd validation #1506
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1506 +/- ##
==========================================
+ Coverage 76.57% 76.76% +0.19%
==========================================
Files 608 609 +1
Lines 45385 45938 +553
Branches 798 798
==========================================
+ Hits 34753 35266 +513
- Misses 10544 10585 +41
+ Partials 88 87 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
||
require 'openc3/packets/command_validator' | ||
|
||
class CmdValidator < OpenC3::CommandValidator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name is kinda generic. Should probably Include the target name in the class name. InstCmdValidator.
from openc3.api import * | ||
|
||
|
||
class CmdValidator(CommandValidator): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
InstCommandValidator
openc3/python/tester.py
Outdated
@@ -0,0 +1 @@ | |||
print('Hello World') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this?
openc3/lib/openc3/packets/packet.rb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs updates to as_json, from_json, and to_config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs updates to as_json, from_json, to_config
Quality Gate passedIssues Measures |
closes #1311
closes #1312