Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmd validation #1506

Merged
merged 11 commits into from
Sep 5, 2024
Merged

Cmd validation #1506

merged 11 commits into from
Sep 5, 2024

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Aug 30, 2024

closes #1311
closes #1312

@jmthomas jmthomas requested a review from ryanmelt August 30, 2024 22:51
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.76%. Comparing base (9a770f6) to head (6f710bf).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1506      +/-   ##
==========================================
+ Coverage   76.57%   76.76%   +0.19%     
==========================================
  Files         608      609       +1     
  Lines       45385    45938     +553     
  Branches      798      798              
==========================================
+ Hits        34753    35266     +513     
- Misses      10544    10585      +41     
+ Partials       88       87       -1     
Flag Coverage Δ
frontend 55.85% <ø> (+0.03%) ⬆️
python 84.61% <ø> (+0.42%) ⬆️
ruby-api 49.00% <ø> (ø)
ruby-backend 82.23% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


require 'openc3/packets/command_validator'

class CmdValidator < OpenC3::CommandValidator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name is kinda generic. Should probably Include the target name in the class name. InstCmdValidator.

from openc3.api import *


class CmdValidator(CommandValidator):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InstCommandValidator

@@ -0,0 +1 @@
print('Hello World')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs updates to as_json, from_json, and to_config.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs updates to as_json, from_json, to_config

Copy link

sonarqubecloud bot commented Sep 5, 2024

@jmthomas jmthomas merged commit 68ec753 into main Sep 5, 2024
27 checks passed
@jmthomas jmthomas deleted the cmd_validation branch September 5, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command Postcheck Command Precheck
2 participants