Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applied OPENC3_OPERATOR_HOSTNAME to json_api.rb #1511

Conversation

stephen-ritter
Copy link

@stephen-ritter stephen-ritter commented Sep 4, 2024

This basically copies the same structure as what is in microservices_controller.rb and allowing the operator hostname to be set through the OPENC3_OPERATOR_HOSTNAME environment variable.

Copy link

sonarqubecloud bot commented Sep 4, 2024

@jmthomas jmthomas requested a review from ryanmelt September 6, 2024 01:43
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.58%. Comparing base (9a770f6) to head (4ebae23).
Report is 60 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1511      +/-   ##
==========================================
+ Coverage   76.57%   76.58%   +0.01%     
==========================================
  Files         608      608              
  Lines       45385    45385              
  Branches      798      798              
==========================================
+ Hits        34753    34759       +6     
+ Misses      10544    10538       -6     
  Partials       88       88              
Flag Coverage Δ
frontend 55.80% <ø> (-0.02%) ⬇️
python 84.24% <ø> (+0.05%) ⬆️
ruby-api 49.00% <ø> (ø)
ruby-backend 82.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanmelt ryanmelt merged commit bae770e into OpenC3:main Sep 18, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants