Add runner role to SR #1519
Merged
Add runner role to SR #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1519 +/- ##
==========================================
+ Coverage 76.57% 76.75% +0.18%
==========================================
Files 608 609 +1
Lines 45385 45942 +557
Branches 798 800 +2
==========================================
+ Hits 34753 35265 +512
- Misses 10544 10589 +45
Partials 88 88
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ryanmelt
requested changes
Sep 15, 2024
| @@ -900,6 +900,9 @@ export default { | |||
| if (role == 'admin' || role == 'operator') { | |||
| this.readOnlyUser = false | |||
| this.executeUser = true | |||
| } else if (role == 'runner') { | |||
| this.readOnlyUser = true | |||
There was a problem hiding this comment.
This line isn't needed and could cause problems if a user had both operater and runner.
|
ryanmelt
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.