Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SR line delay menu option and log line delay changes #1540

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Conversation

jmthomas
Copy link
Member

closes #1467

@jmthomas jmthomas requested a review from ryanmelt September 14, 2024 02:33
@jmthomas
Copy link
Member Author

jmthomas commented Sep 14, 2024

Thought about adding menu option to change delay but this was quick and easy and hopefully brings more awareness to the api method. Plus added logging whenever the api method is called.
Screenshot 2024-09-13 at 8 30 46 PM

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.76%. Comparing base (57235b3) to head (676b2df).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
...riptrunner/src/tools/ScriptRunner/ScriptRunner.vue 0.00% 2 Missing ⚠️
...mos-script-runner-api/app/models/running_script.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1540      +/-   ##
==========================================
+ Coverage   76.74%   76.76%   +0.01%     
==========================================
  Files         609      609              
  Lines       45938    45943       +5     
  Branches      798      798              
==========================================
+ Hits        35257    35269      +12     
+ Misses      10593    10587       -6     
+ Partials       88       87       -1     
Flag Coverage Δ
frontend 55.85% <0.00%> (+0.06%) ⬆️
python 84.61% <ø> (+0.03%) ⬆️
ruby-api 48.98% <0.00%> (-0.02%) ⬇️
ruby-backend 82.23% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmthomas
Copy link
Member Author

jmthomas commented Sep 14, 2024

Ruby script like this:

set_line_delay(1)
puts "HI"
puts "OK"
set_line_delay(0)
puts "HI"
puts "OK"

results in script message:

2024/09/14 03:40:44.936 (SCRIPTRUNNER): Starting script: 2024_09_13_20_43_15_013_temp.rb, line_delay = 0.1

and in log like this:

2024/09/14 03:40:44.912 (SCRIPTRUNNER): Script config/DEFAULT/targets/__TEMP__/2024_09_13_20_43_15_013_temp.rb spawned in 0.900595709 seconds <ruby 3.2.4>
2024/09/14 03:40:45.100 (2024_09_13_20_43_15_013_temp.rb:1): set_line_delay(1)
2024/09/14 03:40:46.102 (2024_09_13_20_43_15_013_temp.rb:2): HI
2024/09/14 03:40:47.103 (2024_09_13_20_43_15_013_temp.rb:3): OK
2024/09/14 03:40:48.104 (2024_09_13_20_43_15_013_temp.rb:4): set_line_delay(0)
2024/09/14 03:40:48.105 (2024_09_13_20_43_15_013_temp.rb:5): HI
2024/09/14 03:40:48.106 (2024_09_13_20_43_15_013_temp.rb:6): OK

Python:

set_line_delay(1)
print("HI")
print("OK")
set_line_delay(0)
print("HI")
print("OK")

script message:

2024-09-14T03:39:56.457548Z (SCRIPTRUNNER): Starting script: 2024_09_13_20_43_15_013_temp.py, line_delay = 0.1

log:

2024-09-14T03:22:25.517405Z (SCRIPTRUNNER): Script config/DEFAULT/targets/__TEMP__/2024_09_13_20_43_15_013_temp.py spawned in 0.650700569152832 seconds <python 3.11.8 (main, Feb 19 2024, 22:58:08) [GCC 12.2.1 20220924]>
2024-09-14T03:22:25.675240Z (2024_09_13_20_43_15_013_temp.py:1): set_line_delay(1)
2024-09-14T03:22:26.677662Z (2024_09_13_20_43_15_013_temp.py:2): HI
2024-09-14T03:22:27.678344Z (2024_09_13_20_43_15_013_temp.py:3): OK
2024-09-14T03:22:28.681637Z (2024_09_13_20_43_15_013_temp.py:4): set_line_delay(0)
2024-09-14T03:22:28.682547Z (2024_09_13_20_43_15_013_temp.py:5): HI
2024-09-14T03:22:28.683029Z (2024_09_13_20_43_15_013_temp.py:6): OK

@jmthomas jmthomas changed the title Add Edit menu option and log line delay changes SR line delay menu option and log line delay changes Sep 14, 2024
Copy link

@@ -247,6 +247,9 @@ export default {
(this.valueId.includes('PACKET_TIMEFORMATTED') ||
this.valueId.includes('RECEIVED_TIMEFORMATTED'))
) {
// Our dates have / rather than - which results in an invalid date on old browsers
// when they call new Date(value)
value = value.replaceAll('/', '-')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed this on another program with an old browser

@ryanmelt ryanmelt merged commit b6e77d0 into main Sep 18, 2024
27 checks passed
@ryanmelt ryanmelt deleted the line_delay branch September 18, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better expose the line delay feature
2 participants