-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SR line delay menu option and log line delay changes #1540
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1540 +/- ##
==========================================
+ Coverage 76.74% 76.76% +0.01%
==========================================
Files 609 609
Lines 45938 45943 +5
Branches 798 798
==========================================
+ Hits 35257 35269 +12
+ Misses 10593 10587 -6
+ Partials 88 87 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Ruby script like this:
results in script message:
and in log like this:
Python:
script message:
log:
|
Quality Gate passedIssues Measures |
@@ -247,6 +247,9 @@ export default { | |||
(this.valueId.includes('PACKET_TIMEFORMATTED') || | |||
this.valueId.includes('RECEIVED_TIMEFORMATTED')) | |||
) { | |||
// Our dates have / rather than - which results in an invalid date on old browsers | |||
// when they call new Date(value) | |||
value = value.replaceAll('/', '-') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed this on another program with an old browser
closes #1467