Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beginning to address the SonarCloud Highs #1546

Merged
merged 11 commits into from
Oct 24, 2024
Merged

beginning to address the SonarCloud Highs #1546

merged 11 commits into from
Oct 24, 2024

Conversation

JL-Brothers
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 54 lines in your changes missing coverage. Please review.

Project coverage is 76.41%. Comparing base (06e9234) to head (83bd5c2).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...mos-script-runner-api/app/models/running_script.rb 5.26% 36 Missing ⚠️
...-cmd-tlm-api/app/controllers/trigger_controller.rb 16.66% 5 Missing ⚠️
...cmd-tlm-api/app/controllers/reaction_controller.rb 33.33% 4 Missing ⚠️
openc3/lib/openc3/ccsds/ccsds_parser.rb 60.00% 2 Missing ⚠️
...enc3/lib/openc3/operators/microservice_operator.rb 0.00% 2 Missing ⚠️
...cmd-tlm-api/app/controllers/activity_controller.rb 80.00% 1 Missing ⚠️
.../app/controllers/script_autocomplete_controller.rb 0.00% 1 Missing ⚠️
...3-cosmos-cmd-tlm-api/app/models/messages_thread.rb 0.00% 1 Missing ⚠️
...lib/openc3/microservices/interface_microservice.rb 0.00% 1 Missing ⚠️
openc3/lib/openc3/microservices/microservice.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1546      +/-   ##
==========================================
- Coverage   76.43%   76.41%   -0.03%     
==========================================
  Files         618      618              
  Lines       46874    46891      +17     
  Branches      849      849              
==========================================
+ Hits        35829    35831       +2     
- Misses      10949    10964      +15     
  Partials       96       96              
Flag Coverage Δ
frontend 56.12% <ø> (-0.07%) ⬇️
ruby-api 47.60% <26.15%> (+0.05%) ⬆️
ruby-backend 82.54% <76.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

when 'FATAL'
return log_entry
else
return log_entry
end
# when "FATAL" fall through and return the log_entry
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comment.

@jmthomas jmthomas marked this pull request as ready for review October 17, 2024 22:18
@ryanmelt ryanmelt merged commit 6b5acfc into main Oct 24, 2024
15 of 17 checks passed
@ryanmelt ryanmelt deleted the sonarcloud-highs branch October 24, 2024 03:24
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants