Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deterministic recalculate bit offsets #1577

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

ryanmelt
Copy link
Member

Fixes issues with mixed types of variable bit size items, and resolves ambiguity based on item create order.

@ryanmelt ryanmelt requested a review from jmthomas September 26, 2024 16:34
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.03%. Comparing base (5e4b7a0) to head (9d28103).
Report is 49 commits behind head on main.

Files with missing lines Patch % Lines
openc3/lib/openc3/packets/structure_item.rb 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1577      +/-   ##
==========================================
+ Coverage   77.02%   77.03%   +0.01%     
==========================================
  Files         611      613       +2     
  Lines       46000    46049      +49     
  Branches      800      802       +2     
==========================================
+ Hits        35431    35475      +44     
- Misses      10481    10486       +5     
  Partials       88       88              
Flag Coverage Δ
frontend 55.67% <ø> (-0.11%) ⬇️
python 84.61% <ø> (+<0.01%) ⬆️
ruby-api 49.01% <ø> (+0.15%) ⬆️
ruby-backend 82.83% <90.47%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added a bit to the test to actually read the values back. Check it out and after it all passes it's ready to merge.

Copy link

@ryanmelt ryanmelt merged commit 593df2d into main Sep 27, 2024
27 checks passed
@ryanmelt ryanmelt deleted the deterministic_recalculate_bit_offsets branch September 27, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants