Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python tcpip_server_interface #1578

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Fix python tcpip_server_interface #1578

merged 2 commits into from
Sep 30, 2024

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Sep 26, 2024

closes #1572

I created an interface in the demo by doing:

INTERFACE TCPIP_INT openc3/interfaces/tcpip_server_interface.py 52001 52001 10.0 None
  MAP_TARGET EXAMPLE

And then exposed port 52001 in the compose.yaml. I was able to talk to it via nc localhost 52001 and see the client number increase and the text show up in UNKNOWN.

Ideally we would have a better test case for this like converting the TEMPLATED target to python. However that port looks a little bit involved because of the use of InterfaceThread from tools/cmd_tlm_server/interface_thread.rb which currently has no Python equivalent.

@jmthomas jmthomas requested a review from ryanmelt September 26, 2024 16:56
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.02%. Comparing base (54a56de) to head (71e40e0).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1578      +/-   ##
==========================================
- Coverage   77.03%   77.02%   -0.01%     
==========================================
  Files         613      613              
  Lines       46056    46058       +2     
  Branches      802      802              
==========================================
+ Hits        35477    35478       +1     
- Misses      10491    10493       +2     
+ Partials       88       87       -1     
Flag Coverage Δ
frontend 55.70% <ø> (+0.03%) ⬆️
python 84.59% <ø> (-0.02%) ⬇️
ruby-api 49.01% <ø> (ø)
ruby-backend 82.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ryanmelt ryanmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python unit tests failing

Copy link

@jmthomas
Copy link
Member Author

Python unit tests failing

Now passing!

@ryanmelt ryanmelt merged commit 472db78 into main Sep 30, 2024
27 checks passed
@ryanmelt ryanmelt deleted the python_tcpip_server branch September 30, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants