Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LogMessages history #1587

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Fix LogMessages history #1587

merged 1 commit into from
Sep 30, 2024

Conversation

jmthomas
Copy link
Member

closes #1586

@jmthomas jmthomas requested a review from ryanmelt September 28, 2024 22:30
@jmthomas jmthomas changed the title Fix history_count parameter Fix LogMessages history Sep 28, 2024
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.06%. Comparing base (16f20c2) to head (a08d00b).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1587      +/-   ##
==========================================
+ Coverage   77.04%   77.06%   +0.02%     
==========================================
  Files         613      613              
  Lines       46048    46048              
  Branches      802      802              
==========================================
+ Hits        35477    35487      +10     
+ Misses      10483    10473      -10     
  Partials       88       88              
Flag Coverage Δ
frontend 55.88% <ø> (+0.19%) ⬆️
python 84.62% <ø> (-0.01%) ⬇️
ruby-api 49.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@ryanmelt ryanmelt merged commit be0e85c into main Sep 30, 2024
25 of 27 checks passed
@ryanmelt ryanmelt deleted the history branch September 30, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CmdTlmServer LogMessages history broken
2 participants