cli updates #1588
Merged
cli updates #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1588 +/- ##
==========================================
- Coverage 77.03% 76.78% -0.26%
==========================================
Files 613 613
Lines 46056 46314 +258
Branches 803 805 +2
==========================================
+ Hits 35480 35560 +80
- Misses 10489 10667 +178
Partials 87 87
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jmthomas
approved these changes
Oct 1, 2024
| data["url"] = url | ||
| if other is not None: | ||
| data = data | other | ||
| return data |
There was a problem hiding this comment.
Good checks throughout for not None
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some comments and removed cliroot from the .sh version. I see nothing good coming from cliroot on linux at this point. May still be needed on Windows for certain environments.