Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dv items #1593

Merged
merged 5 commits into from
Oct 1, 2024
Merged

Dv items #1593

merged 5 commits into from
Oct 1, 2024

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Oct 1, 2024

closes #1458

@jmthomas
Copy link
Member Author

jmthomas commented Oct 1, 2024

This is going to need some additional playwright testing

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 76.97842% with 32 lines in your changes missing coverage. Please review.

Project coverage is 76.79%. Comparing base (a467d70) to head (0fc543a).
Report is 138 commits behind head on main.

Files with missing lines Patch % Lines
...ool-dataviewer/src/tools/DataViewer/DataViewer.vue 70.75% 26 Missing and 5 partials ⚠️
openc3/lib/openc3/models/widget_model.rb 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1593      +/-   ##
==========================================
+ Coverage   75.33%   76.79%   +1.46%     
==========================================
  Files         609      614       +5     
  Lines       45922    46376     +454     
  Branches      799      827      +28     
==========================================
+ Hits        34595    35616    +1021     
+ Misses      11239    10668     -571     
- Partials       88       92       +4     
Flag Coverage Δ
frontend 56.20% <76.86%> (+0.38%) ⬆️
python 84.62% <ø> (+<0.01%) ⬆️
ruby-api 47.62% <ø> (-1.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Oct 1, 2024

@jmthomas jmthomas merged commit 44abfe2 into main Oct 1, 2024
25 of 27 checks passed
@jmthomas jmthomas deleted the dv_items branch October 1, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to log selected telemetry value
2 participants