Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key to PacketViewer table #1611

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Add key to PacketViewer table #1611

merged 1 commit into from
Oct 7, 2024

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Oct 3, 2024

closes #1610

Screenshot 2024-10-03 at 2 21 12 PM

@jmthomas jmthomas requested a review from ryanmelt October 3, 2024 20:26
Copy link

sonarqubecloud bot commented Oct 3, 2024

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.80%. Comparing base (7725769) to head (83e7fd4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1611      +/-   ##
==========================================
+ Coverage   76.77%   76.80%   +0.03%     
==========================================
  Files         614      614              
  Lines       46403    46403              
  Branches      827      827              
==========================================
+ Hits        35628    35642      +14     
+ Misses      10683    10670      -13     
+ Partials       92       91       -1     
Flag Coverage Δ
frontend 56.34% <ø> (+0.13%) ⬆️
python 84.60% <ø> (+0.04%) ⬆️
ruby-api 47.62% <ø> (ø)
ruby-backend 82.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmthomas jmthomas merged commit 1bb2fc7 into main Oct 7, 2024
27 checks passed
@jmthomas jmthomas deleted the pv_items branch October 7, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PacketViewer search breaks items
1 participant