New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve TargetPacketItemChooser behavior #1613

Merged

ryanmelt merged 2 commits into main from tpic

Oct 12, 2024

Member

jmthomas commented Oct 3, 2024

closes #1597


          Improve TargetPacketItemChooser behavior

7c788f2

jmthomas requested a review from ryanmelt

October 3, 2024 20:52

codecov bot commented Oct 3, 2024 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.80%. Comparing base (7725769) to head (56d5b0c).
Report is 26 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1613      +/-   ##
==========================================
+ Coverage   76.77%   76.80%   +0.02%     
==========================================
  Files         614      614              
  Lines       46403    46403              
  Branches      827      827              
==========================================
+ Hits        35628    35639      +11     
+ Misses      10683    10673      -10     
+ Partials       92       91       -1

Flag	Coverage Δ
frontend	`56.27% <ø> (+0.06%)`	⬆️
python	`84.61% <ø> (+0.05%)`	⬆️
ruby-api	`47.62% <ø> (ø)`
ruby-backend	`82.82% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


          Fix passing selectedTargetName

56d5b0c

sonarqubecloud bot commented Oct 3, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ryanmelt approved these changes

View reviewed changes

ryanmelt merged commit de8398a into main

34 checks passed

ryanmelt deleted the tpic branch

October 12, 2024 02:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet