Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ScriptRunner Execute text when file modified #1637

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Fix ScriptRunner Execute text when file modified #1637

merged 1 commit into from
Oct 24, 2024

Conversation

jmthomas
Copy link
Member

closes #1488

@jmthomas jmthomas requested a review from ryanmelt October 18, 2024 22:26
}
if (extension !== 'rb' && extension !== 'py') {
extension = 'rb' // Still default to Ruby if we can't determine
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing I think the real issue was we were pushing files with .rb * in the filename and then the file could not be found.

Copy link
Member Author

@jmthomas jmthomas Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that if the file completes early and we hit a route like /tools/scriptrunner/99 which doesn't exist, we already open up the Completed Scripts pane and show that. Now that we have the ID in the completed scripts it should be easy to make the connection.

Copy link

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 76.40%. Comparing base (6c85e08) to head (d72dc34).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
...riptrunner/src/tools/ScriptRunner/ScriptRunner.vue 0.00% 4 Missing ⚠️
...mos-script-runner-api/app/models/running_script.rb 0.00% 2 Missing ⚠️
...s-script-runner-api/app/models/completed_script.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1637      +/-   ##
==========================================
- Coverage   76.40%   76.40%   -0.01%     
==========================================
  Files         618      618              
  Lines       46858    46862       +4     
  Branches      845      847       +2     
==========================================
+ Hits        35803    35804       +1     
- Misses      10959    10962       +3     
  Partials       96       96              
Flag Coverage Δ
frontend 56.09% <0.00%> (-0.04%) ⬇️
python 83.87% <ø> (+<0.01%) ⬆️
ruby-api 47.59% <0.00%> (ø)
ruby-backend 82.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanmelt ryanmelt merged commit f933f86 into main Oct 24, 2024
27 checks passed
@ryanmelt ryanmelt deleted the sr_exec branch October 24, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Execute Selection and Run From Here Can Complete Too Fast...
2 participants