View Script Logs / Report

[jmthomas]

closes #1549

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 76.48%. Comparing base (3912e0c) to head (c0fd630).
Report is 23 commits behind head on main.

Files with missing lines	Patch %	Lines
...-cmd-tlm-api/app/controllers/storage_controller.rb	0.00%	16 Missing ⚠️
...ptrunner/src/tools/ScriptRunner/RunningScripts.vue	0.00%	10 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1655      +/-   ##
==========================================
- Coverage   76.52%   76.48%   -0.05%     
==========================================
  Files         618      618              
  Lines       46920    46942      +22     
  Branches      849      850       +1     
==========================================
- Hits        35904    35902       -2     
- Misses      10920    10944      +24     
  Partials       96       96              

Flag	Coverage Δ
frontend	55.99% <0.00%> (-0.12%)	⬇️
python	83.91% <ø> (-0.01%)	⬇️
ruby-api	48.69% <0.00%> (-0.14%)	⬇️
ruby-backend	82.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ryanmelt]

Why no bucket before?

[jmthomas]

We never did a download from a bucket before ... just volumes. We always used the get_download_presigned_request instead because the result was always a file to download. Now we're downloading to memory so we can display.

[jmthomas]

[ryanmelt]

filename at line 125 of storage_controller is not sanitized

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.7% Duplication on New Code

See analysis details on SonarCloud