Remove some deprecated items for COSMOS 6 #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1659 +/- ##
==========================================
+ Coverage 76.15% 76.32% +0.17%
==========================================
Files 602 603 +1
Lines 45733 46096 +363
Branches 822 837 +15
==========================================
+ Hits 34828 35183 +355
- Misses 10810 10817 +7
- Partials 95 96 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ryanmelt
requested changes
Oct 24, 2024
| @@ -44,9 +44,6 @@ class Table < Packet | |||
| # Constructor for a TableDefinition | |||
| def initialize(name, endianness, type, description, filename) | |||
| super(TARGET, name, endianness, description, '', TableItem) | |||
| # ONE_DIMENSIONAL and TWO_DIMENSIONAL are deprecated so translate | |||
There was a problem hiding this comment.
I think we should remove documentation on ONE_DIMENSTIONAL/TWO_DIMENSIONAL (so all text references), but it doesn't hurt to leave the keywords and not break COSMOS 4 table definitions.
ryanmelt
approved these changes
Nov 8, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TlmViewer has removed the SECTIONHEADER widget.
Ruby httpclient has been removed from the dependencies. This has no impact unless you've written a custom interface that explicitly uses it. Migrate to faraday.
A custom BAE (Ball Aerospace) interface called LincInterface (linc_interface.rb) has been removed from the built-in interfaces. Targets using this interface will need to explicitly bundle it in the target's lib directory.
The openc3/interfaces/protocols/override_protocol.rb has been removed.
The CLI MIGRATE option to port a COSMOS 4 configuration to COSMOS 5 has been removed. If you need to port from COSMOS 4 to COSMOS 6 please first use the migration tool in COSMOS 5. From there you can immediately transition to COSMOS 6.