Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharded Operator Support #1709

Merged
merged 2 commits into from
Nov 28, 2024
Merged

Sharded Operator Support #1709

merged 2 commits into from
Nov 28, 2024

Conversation

ryanmelt
Copy link
Member

No description provided.

@ryanmelt ryanmelt requested a review from jmthomas November 14, 2024 22:47
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 62.96296% with 10 lines in your changes missing coverage. Please review.

Project coverage is 76.30%. Comparing base (19c5fef) to head (38a8a75).
Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
...enc3/lib/openc3/operators/microservice_operator.rb 25.00% 3 Missing ⚠️
openc3/lib/openc3/models/interface_model.rb 50.00% 2 Missing ⚠️
openc3/lib/openc3/models/microservice_model.rb 50.00% 2 Missing ⚠️
openc3/lib/openc3/models/target_model.rb 50.00% 2 Missing ⚠️
openc3/lib/openc3/models/scope_model.rb 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1709      +/-   ##
==========================================
- Coverage   76.31%   76.30%   -0.01%     
==========================================
  Files         603      603              
  Lines       46097    46118      +21     
  Branches      844      844              
==========================================
+ Hits        35179    35192      +13     
- Misses      10822    10830       +8     
  Partials       96       96              
Flag Coverage Δ
python 83.98% <ø> (+<0.01%) ⬆️
ruby-api 48.70% <ø> (ø)
ruby-backend 82.15% <62.96%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this require a corresponding Enterprise PR? I assume most of the work is there.

@@ -42,6 +42,7 @@ def initialize
@new_microservices = {}
@changed_microservices = {}
@removed_microservices = {}
@shard = ENV['OPENC3_SHARD'] || 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When / where does OPENC3_SHARD get set?

@ryanmelt ryanmelt merged commit 29cd729 into main Nov 28, 2024
26 of 27 checks passed
@ryanmelt ryanmelt deleted the sharded_operator branch November 28, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants