Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish a couple things #1757

Merged
merged 8 commits into from
Dec 14, 2024
Merged

Polish a couple things #1757

merged 8 commits into from
Dec 14, 2024

Conversation

ryan-pratt
Copy link
Contributor

No description provided.

@ryan-pratt ryan-pratt requested a review from jmthomas December 12, 2024 19:27
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.59%. Comparing base (5af74dc) to head (5aad83f).
Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1757   +/-   ##
=======================================
  Coverage   79.59%   79.59%           
=======================================
  Files         517      517           
  Lines       40713    40713           
=======================================
+ Hits        32404    32406    +2     
+ Misses       8309     8307    -2     
Flag Coverage Δ
python 84.31% <ø> (+0.01%) ⬆️
ruby-api 48.64% <ø> (ø)
ruby-backend 82.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve but let's have @ryanmelt review

@@ -50,7 +50,7 @@
disabled
hide-details
density="compact"
variant="underlined"
variant="outlined"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outlined or filled to match the non-state typical value textfield. It looked a little weird to me to have the empty outlined box before you select a state. @ryanmelt you should check it out and see if this is what you were looking for.

@@ -73,6 +73,7 @@ export default {
message: 'Overall message here',
},
timeout: null,
noToastPaths: ['/login'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix, that was bugging me on login

@jmthomas
Copy link
Member

Here's how the screen overlay works:
Screenshot 2024-12-13 at 6 22 16 AM

@jmthomas
Copy link
Member

I fixed the flaky Bucket Explorer playwright test in 22c4bb0

@ryanmelt ryanmelt merged commit 19152fc into main Dec 14, 2024
27 of 28 checks passed
@ryanmelt ryanmelt deleted the release-polish branch December 14, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants