-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish a couple things #1757
Polish a couple things #1757
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1757 +/- ##
=======================================
Coverage 79.59% 79.59%
=======================================
Files 517 517
Lines 40713 40713
=======================================
+ Hits 32404 32406 +2
+ Misses 8309 8307 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve but let's have @ryanmelt review
@@ -50,7 +50,7 @@ | |||
disabled | |||
hide-details | |||
density="compact" | |||
variant="underlined" | |||
variant="outlined" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
outlined
or filled
to match the non-state typical value textfield. It looked a little weird to me to have the empty outlined box before you select a state. @ryanmelt you should check it out and see if this is what you were looking for.
@@ -73,6 +73,7 @@ export default { | |||
message: 'Overall message here', | |||
}, | |||
timeout: null, | |||
noToastPaths: ['/login'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good fix, that was bugging me on login
Quality Gate passedIssues Measures |
I fixed the flaky Bucket Explorer playwright test in 22c4bb0 |
No description provided.