Update package_audit for vue.global and vuetify-labs #1770
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1770 +/- ##
==========================================
- Coverage 79.58% 79.58% -0.01%
==========================================
Files 517 517
Lines 40736 40737 +1
==========================================
- Hits 32420 32419 -1
- Misses 8316 8318 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| `curl https://cdnjs.cloudflare.com/ajax/libs/#{package}/#{latest}/#{package}.min.css --output public/css/#{package}-#{latest}.min.css` | ||
| `curl https://cdnjs.cloudflare.com/ajax/libs/#{package}/#{latest}/#{package}.min.js --output public/js/#{package}-#{latest}.min.js` | ||
| `curl https://cdnjs.cloudflare.com/ajax/libs/#{package}/#{latest}/#{package}-labs.min.css --output public/css/#{package}-labs-#{latest}.min.css` | ||
| `curl https://cdnjs.cloudflare.com/ajax/libs/#{package}/#{latest}/#{package}-labs.min.js --output public/js/#{package}-labs-#{latest}.min.js` |
There was a problem hiding this comment.
I don't currently have the .min version in index.html. Need to update that if wwe change to the min js version.
Same for vue.
There was a problem hiding this comment.
I think we want the minified version right? I'll update.
scripts/release/package_audit_lib.rb
Outdated
| @@ -422,15 +422,18 @@ def check_tool_base(path, base_pkgs) | |||
| # Handle nuances in individual packages | |||
| # Search here to get the URLs: https://cdnjs.com/ | |||
| case package | |||
| when 'vue' | |||
| `curl https://cdnjs.cloudflare.com/ajax/libs/#{package}/#{latest}/#{package}.global.min.js --output public/js/#{package}.global-#{latest}.min.js` | |||
There was a problem hiding this comment.
Do we even need this? I think we're only referencing global.prod
|
No description provided.