Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nice error message for widget items without limits #1786

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Conversation

jmthomas
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.59%. Comparing base (620b543) to head (c368633).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1786      +/-   ##
==========================================
+ Coverage   79.56%   79.59%   +0.02%     
==========================================
  Files         517      517              
  Lines       40737    40737              
==========================================
+ Hits        32414    32423       +9     
+ Misses       8323     8314       -9     
Flag Coverage Δ
python 84.32% <ø> (+0.06%) ⬆️
ruby-api 48.64% <ø> (ø)
ruby-backend 82.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines 782 to 785
.v-textarea .v-field__input {
-webkit-mask-image: unset;
mask-image: unset;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removes that little drop shadow on the error screen

@jmthomas
Copy link
Member Author

Screenshot 2024-12-20 at 12 54 29 PM

@jmthomas jmthomas merged commit 3467e57 into main Dec 20, 2024
27 of 28 checks passed
@jmthomas jmthomas deleted the limits_widgets branch December 20, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants